Home / SumatraPDF Crashes when closing documents from the tab

ianas

As the title says I’ve been experiencing crashes when I try to close a document ether with the middle mouse click or the tab x button
a debug session shows the culprit to be

github.com

sumatrapdfreader/sumatrapdf/blob/master/src/Colors.cpp#L248




if (col == AppColor::TabClickedCloseX) {

    return GetAppColor(AppColor::TabHoveredCloseX);

}



if (col == AppColor::TabClickedCloseCircle) {

    auto c = GetAppColor(AppColor::TabSelectedCloseCircle);

    AdjustLightness2(c, -10);

    return c;

}



CrashIf(true);

return COL_WINDOW_BG;

}



void GetFixedPageUiColors(COLORREF& text, COLORREF& bg) {

#if 0

text = GetCurrentTheme()->document.textColor;

bg = GetCurrentTheme()->document.backgroundColor;

#endif

I’m using the latest git 9727 (svn 10727) it happens with my build as well as the current prerelease downloaded from https://www.sumatrapdfreader.org/prerelease.html

kjk

Sorry about that. Should be fixed by https://github.com/sumatrapdfreader/sumatrapdf/commit/69912675c766b6325f38036913dcf0505a00be36

Pre-release will be updated shortly.